Make the panel position and the label width settings
Two things that were constants and had no business being constants. Placement: the box (left, centre, right) and the index within it. The default is unchanged -- centre, index 1, immediately right of the clock -- and an index past the end of a box lands at the end, so a large one means "last". Applied at once, no reload. Moving is done by rebuilding the indicator rather than by moving the actor. addToStatusArea is what registers it under the uuid and there is no documented call to move one between boxes; everything else reaches into Main.panel's private boxes. It costs one re-read of a few small state files and only when the setting is touched. Label width: three characters by default, settable up to ten, not down. Three is enough to keep initials apart and narrow enough not to shove the clock about; below three, distinct projects start sharing a label. A wider label takes more initials rather than a longer prefix -- a prefix collapses dev-skills and dev-conventions at any width -- so dev-skills stays "ds" however wide the setting, while claude-code-gnome-extension becomes "ccge" at four. A disambiguating digit still eats into the label instead of extending past the width, so a chip that gains one does not push the row. Sticky labels work against that setting: kept labels are kept whatever width they were cut at, so widening would leave every session on screen at its old width until it ended. The width is therefore the one thing that discards the map -- a relabelling that was asked for is not a label moving under your hand. The combo row is bound by hand: Gio.Settings.bind maps a boolean to 'active' and an int to 'value', but a string to a selected index needs bind_with_mapping, which is not introspectable. Only the write direction is wired up, and the test covers it, because a row that stores its index instead of its value looks fine until the shell reads the key. Fixed on the way, found by watching the centre box grow 2 -> 3 -> 4 -> 5 across four moves: PanelMenu.ButtonBox connects `this._onDestroy.bind(this)` in its _init, and its _onDestroy is what destroys the container -- the St.Bin the panel box actually holds. The name resolves through the prototype chain, so this extension's own _onDestroy had been silently replacing the shell's since the beginning, leaving an empty container in the panel on every teardown. Renamed to _teardown; the box now stays at two children across moves and across enable/disable cycles. Verified in a nested shell on a copy of the extension carrying temporary logging, since the shell refuses screenshots to non-portal callers: every box, indices 0, 1 and 9, and widths 3, 5, 8, 10 and back, with no JS errors and no leftover actors.
This commit is contained in:
@@ -15,15 +15,38 @@ export default class ClaudeCodeStatusPreferences extends ExtensionPreferences {
|
||||
});
|
||||
window.add(page);
|
||||
|
||||
const dispGroup = new Adw.PreferencesGroup({ title: _('Panel') });
|
||||
const placeGroup = new Adw.PreferencesGroup({
|
||||
title: _('Placement'),
|
||||
description: _('Where the row of chips sits in the top bar. Applied at once — no need to reload.'),
|
||||
});
|
||||
page.add(placeGroup);
|
||||
|
||||
placeGroup.add(this._comboRow(settings, 'panel-box',
|
||||
_('Panel box'),
|
||||
_('The centre box holds the clock; the right one is the system status area.'),
|
||||
[
|
||||
{ value: 'left', label: _('Left') },
|
||||
{ value: 'center', label: _('Centre') },
|
||||
{ value: 'right', label: _('Right') },
|
||||
]));
|
||||
placeGroup.add(this._spinRow(settings, 'panel-position',
|
||||
_('Position in that box'),
|
||||
_('0 is first. In the centre box, 1 puts the chips just right of the clock. Past the end means last.'),
|
||||
0, 10));
|
||||
|
||||
const dispGroup = new Adw.PreferencesGroup({ title: _('Chips') });
|
||||
page.add(dispGroup);
|
||||
|
||||
dispGroup.add(this._switchRow(settings, 'show-project-name',
|
||||
_('Label chips with the project'),
|
||||
_('Name the sessions, not just their states.')));
|
||||
dispGroup.add(this._switchRow(settings, 'abbreviate-names',
|
||||
_('Shorten names to three characters'),
|
||||
_('Shorten names'),
|
||||
_('“dev-skills” becomes “ds”. Collisions get a digit by seniority, so a label already on screen never changes.')));
|
||||
dispGroup.add(this._spinRow(settings, 'abbrev-length',
|
||||
_('Label length'),
|
||||
_('Characters a shortened label may use. Three keeps the row narrow; longer reads more like the name. Changing it relabels every session at once.'),
|
||||
3, 10));
|
||||
dispGroup.add(this._spinRow(settings, 'max-chips',
|
||||
_('Chips shown'),
|
||||
_('The most urgent sessions get a chip; the rest are counted as “+N”.'),
|
||||
@@ -118,6 +141,32 @@ export default class ClaudeCodeStatusPreferences extends ExtensionPreferences {
|
||||
return row;
|
||||
}
|
||||
|
||||
/** A string key with a fixed set of values.
|
||||
*
|
||||
* Bound by hand: Gio.Settings.bind maps a boolean to 'active' and an int
|
||||
* to 'value', but a string to a selected index needs bind_with_mapping,
|
||||
* which is not introspectable. The write direction is the only one wired
|
||||
* up -- while this window is open, this row is the only thing that writes
|
||||
* the key, and it is read afresh every time the window is built.
|
||||
*/
|
||||
_comboRow(settings, key, title, subtitle, options) {
|
||||
const row = new Adw.ComboRow({
|
||||
title, subtitle,
|
||||
model: Gtk.StringList.new(options.map(o => o.label)),
|
||||
});
|
||||
const values = options.map(o => o.value);
|
||||
const current = values.indexOf(settings.get_string(key));
|
||||
// Set before connecting, so restoring the stored value is not itself
|
||||
// taken for a change the person made.
|
||||
row.selected = current < 0 ? 0 : current;
|
||||
row.connect('notify::selected', () => {
|
||||
const value = values[row.selected];
|
||||
if (value)
|
||||
settings.set_string(key, value);
|
||||
});
|
||||
return row;
|
||||
}
|
||||
|
||||
_switchRow(settings, key, title, subtitle) {
|
||||
const row = new Adw.SwitchRow({ title, subtitle });
|
||||
settings.bind(key, row, 'active', Gio.SettingsBindFlags.DEFAULT);
|
||||
|
||||
Reference in New Issue
Block a user