av/travian
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve tests

Browse Source
This commit is contained in:
Anton Vakhrushev 2020-04-29 21:19:58 +03:00
parent fa388a1fe3
commit 418655ebff
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Queue/DataStorageTaskProvider.ts
View File

@ -1,6 +1,5 @@
import { DataStorage } from '../DataStorage'; import { DataStorage } from '../DataStorage';
import { uniqId } from '../utils'; import {Task, TaskList, TaskProvider, uniqTaskId} from './TaskProvider';
import { Task, TaskList, TaskProvider } from './TaskProvider';
const NAMESPACE = 'tasks:v1'; const NAMESPACE = 'tasks:v1';
const QUEUE_NAME = 'queue'; const QUEUE_NAME = 'queue';
@ -25,7 +24,7 @@ export class DataStorageTaskProvider implements TaskProvider {
const storedItems = serialized as Array<{ [key: string]: any }>; const storedItems = serialized as Array<{ [key: string]: any }>;
return storedItems.map(i => { return storedItems.map(i => {
const task = new Task(uniqId(), 0, '', {}); const task = new Task(uniqTaskId(), 0, '', {});
return Object.assign(task, i); return Object.assign(task, i);
}); });
} }

1
src/Queue/TaskProvider.ts
View File

@ -36,6 +36,5 @@ export type ImmutableTaskList = ReadonlyArray<Task>;
export interface TaskProvider { export interface TaskProvider {
getTasks(): TaskList; getTasks(): TaskList;
setTasks(tasks: TaskList): void; setTasks(tasks: TaskList): void;
} }

8
tests/Queue/TaskQueueTest.js.ts
View File

@ -11,14 +11,14 @@ describe('Task Queue', function() {
const provider = new ArrayTaskProvider([new Task('1', 0, 'task', {})]); const provider = new ArrayTaskProvider([new Task('1', 0, 'task', {})]);
const queue = new TaskQueue(provider, new NullLogger()); const queue = new TaskQueue(provider, new NullLogger());
const task = queue.get(1); const task = queue.get(1);
expect(task).instanceOf(Task); expect(task).to.be.instanceOf(Task);
}); });
it("Don't get unready task from queue", function() { it("Don't get unready task from queue", function() {
const provider = new ArrayTaskProvider([new Task('1', 5, 'task', {})]); const provider = new ArrayTaskProvider([new Task('1', 5, 'task', {})]);
const queue = new TaskQueue(provider, new NullLogger()); const queue = new TaskQueue(provider, new NullLogger());
const task = queue.get(1); const task = queue.get(1);
expect(task).is.equals(undefined); expect(task).to.be.undefined;
}); });
it('Can remove task by id', function() { it('Can remove task by id', function() {
@ -26,8 +26,8 @@ describe('Task Queue', function() {
const queue = new TaskQueue(provider, new NullLogger()); const queue = new TaskQueue(provider, new NullLogger());
queue.remove('id1'); queue.remove('id1');
const tasks = provider.getTasks(); const tasks = provider.getTasks();
expect(1).is.equals(tasks.length); expect(tasks).to.have.lengthOf(1);
expect(2).is.equals(tasks[0].ts); expect(tasks[0].ts).to.be.equals(2);
}); });
it('Can modify tasks', function() { it('Can modify tasks', function() {