Some refactoring

This commit is contained in:
Anton Vakhrushev 2020-04-29 11:02:13 +03:00
parent 21c773961b
commit 5cb1f2b879
3 changed files with 40 additions and 28 deletions

View File

@ -11,7 +11,7 @@ export function registerAction(constructor: Function) {
actionMap[constructor.name] = constructor;
}
export function createAction(name: string, scheduler: Scheduler): ActionController | undefined {
export function createActionHandler(name: string, scheduler: Scheduler): ActionController | undefined {
const storedFunction = actionMap[name];
if (storedFunction === undefined) {
return undefined;

View File

@ -3,8 +3,8 @@ import { AbortTaskError, ActionError, TryLaterError } from './Errors';
import { Task } from './Queue/TaskQueue';
import { Command } from './Command';
import { TaskQueueRenderer } from './TaskQueueRenderer';
import { createAction } from './Action/ActionController';
import { createTask } from './Task/TaskController';
import { createActionHandler } from './Action/ActionController';
import { createTaskHandler } from './Task/TaskController';
import { ConsoleLogger, Logger } from './Logger';
import { GrabberManager } from './Grabber/GrabberManager';
import { Scheduler } from './Scheduler';
@ -36,29 +36,30 @@ export class Executor {
await waitForLoad();
await sleepMicro();
this.renderInfo();
const sleep = createExecutionLoopSleeper();
while (true) {
await sleep();
if (!this.isPaused()) {
await this.doTaskProcessingStep();
}
}
}
private renderInfo() {
try {
markPage('Executor', this.version);
this.renderTaskQueue();
} catch (e) {
this.logger.warn(e);
}
let skipFirstSleep = true;
while (true) {
if (skipFirstSleep) {
skipFirstSleep = false;
} else {
await sleepMicro();
}
private isPaused(): boolean {
const { pauseTs } = this.executionState.getExecutionSettings();
if (pauseTs > timestamp()) {
continue;
}
await this.doTaskProcessingStep();
}
return pauseTs > timestamp();
}
private renderTaskQueue() {
@ -96,24 +97,24 @@ export class Executor {
}
private async processActionCommand(cmd: Command, task: Task) {
const actionController = createAction(cmd.name, this.scheduler);
this.logger.log('PROCESS ACTION', cmd.name, actionController);
const actionHandler = createActionHandler(cmd.name, this.scheduler);
this.logger.log('PROCESS ACTION', cmd.name, actionHandler);
if (cmd.args.taskId !== task.id) {
throw new ActionError(`Action task id ${cmd.args.taskId} not equal current task id ${task.id}`);
}
if (actionController) {
if (actionHandler) {
this.statistics.incrementAction();
await actionController.run(cmd.args, task);
await actionHandler.run(cmd.args, task);
} else {
this.logger.warn('ACTION NOT FOUND', cmd.name);
}
}
private async processTaskCommand(task: Task) {
const taskController = createTask(task.name, this.scheduler);
this.logger.log('PROCESS TASK', task.name, task, taskController);
if (taskController) {
await taskController.run(task);
const taskHandler = createTaskHandler(task.name, this.scheduler);
this.logger.log('PROCESS TASK', task.name, task, taskHandler);
if (taskHandler) {
await taskHandler.run(task);
} else {
this.logger.warn('TASK NOT FOUND', task.name);
this.scheduler.removeTask(task.id);
@ -153,3 +154,14 @@ export class Executor {
}
}
}
function createExecutionLoopSleeper() {
let skipFirstSleep = true;
return async () => {
if (skipFirstSleep) {
skipFirstSleep = false;
} else {
await sleepMicro();
}
};
}

View File

@ -9,7 +9,7 @@ export function registerTask(constructor: Function) {
taskMap[constructor.name] = constructor;
}
export function createTask(name: string, scheduler: Scheduler): TaskController | undefined {
export function createTaskHandler(name: string, scheduler: Scheduler): TaskController | undefined {
const storedFunction = taskMap[name];
if (storedFunction === undefined) {
return undefined;