Refactoring

src/Task/BuildBuildingTask.ts

@@ -4,18 +4,17 @@ import { ActionDefinition, TaskController } from './TaskController';
 import { Task } from '../Queue/TaskProvider';
 import { path } from '../Helpers/Path';
 import { registerTask, TaskType } from './TaskMap';
+import { taskError } from '../Errors';
+import { goToResourceViewPage } from './ActionBundles';
 
 @registerTask({ type: TaskType.Building })
 export class BuildBuildingTask extends TaskController {
     defineActions(task: Task): Array<ActionDefinition> {
         const args = task.args;
+        const villageId = args.villageId || taskError('No village id');
+
         return [
-            [
+            goToResourceViewPage(villageId),
-                GoToPageAction.name,
-                {
-                    path: path('/dorf1.php', { newdid: args.villageId }),
-                },
-            ],
             [
                 GoToPageAction.name,
                 {

src/Task/ResourcesToLevel.ts

@@ -1,16 +1,15 @@
 import { TaskController, ActionDefinition } from './TaskController';
-import { GoToPageAction } from '../Action/GoToPageAction';
 import { UpgradeResourceToLevel } from '../Action/UpgradeResourceToLevel';
 import { Task } from '../Queue/TaskProvider';
-import { path } from '../Helpers/Path';
 import { registerTask } from './TaskMap';
+import { goToResourceViewPage } from './ActionBundles';
+import { taskError } from '../Errors';
 
 @registerTask()
 export class ResourcesToLevel extends TaskController {
     defineActions(task: Task): Array<ActionDefinition> {
-        return [
+        const villageId = task.args.villageId || taskError('No village id');
-            [GoToPageAction.name, { path: path('/dorf1.php', { newdid: task.args.villageId }) }],
+
-            [UpgradeResourceToLevel.name],
+        return [goToResourceViewPage(villageId), [UpgradeResourceToLevel.name]];
-        ];
     }
 }

src/Task/UpgradeBuildingTask.ts

@@ -4,18 +4,17 @@ import { GoToPageAction } from '../Action/GoToPageAction';
 import { Task } from '../Queue/TaskProvider';
 import { path } from '../Helpers/Path';
 import { registerTask, TaskType } from './TaskMap';
+import { goToResourceViewPage } from './ActionBundles';
+import { taskError } from '../Errors';
 
 @registerTask({ type: TaskType.Building })
 export class UpgradeBuildingTask extends TaskController {
     defineActions(task: Task): Array<ActionDefinition> {
         const args = task.args;
+        const villageId = args.villageId || taskError('No village id');
+
         return [
-            [
+            goToResourceViewPage(villageId),
-                GoToPageAction.name,
-                {
-                    path: path('/dorf1.php', { newdid: args.villageId }),
-                },
-            ],
             [
                 GoToPageAction.name,
                 {