From dfc7d48fd419ed0a4b6fa982976e9dd3d735897a Mon Sep 17 00:00:00 2001 From: Anton Vakhrushev Date: Sat, 18 Jul 2020 17:25:47 +0300 Subject: [PATCH] Split utils functions into set of helper modules --- src/Action/ActionController.ts | 2 +- src/Action/BuildBuildingAction.ts | 2 +- src/Action/CelebrationAction.ts | 2 +- src/Action/FindSendResourcesPath.ts | 2 +- src/Action/ForgeImprovementAction.ts | 2 +- src/Action/SendOnAdventureAction.ts | 2 +- src/Action/TrainTrooperAction.ts | 3 +- src/Action/UpgradeBuildingAction.ts | 2 +- src/Action/UpgradeResourceToLevel.ts | 3 +- src/ControlPanel.ts | 4 +- src/DashboardView/LogList.vue | 5 +- src/DashboardView/Store.ts | 3 +- src/DashboardView/TaskList.vue | 5 +- src/Executor.ts | 3 +- src/Grabber/ForgePageGrabber.ts | 2 +- src/Grabber/GuildHallPageGrabber.ts | 2 +- src/Grabber/VillageBuildingsPageGrabber.ts | 2 +- src/Grabber/VillageOverviewPageGrabber.ts | 3 +- src/Helpers/Browser.ts | 31 +++++ src/Helpers/Collection.ts | 5 + src/Helpers/Convert.ts | 30 +++++ src/Helpers/Format.ts | 6 + src/Helpers/Identity.ts | 15 +++ src/Helpers/Random.ts | 10 ++ src/Helpers/Time.ts | 19 +++ src/Logger.ts | 2 +- src/ModeDetector.ts | 2 +- src/Page/BuildingPage/BuildingPage.ts | 3 +- src/Page/BuildingPage/ForgePage.ts | 3 +- src/Page/BuildingPage/GuildHallPage.ts | 3 +- src/Page/BuildingPage/MarketPage.ts | 3 +- src/Page/BuildingPage/TrooperPage.ts | 3 +- src/Page/BuildingPageController.ts | 2 +- src/Page/HeroPage.ts | 2 +- src/Page/PageDetector.ts | 3 +- src/Page/ResourcesBlock.ts | 2 +- src/Page/SlotBlock.ts | 2 +- src/Page/VillageBlock.ts | 3 +- src/Queue/TaskProvider.ts | 2 +- src/Scheduler.ts | 3 +- src/Statistics.ts | 4 +- src/Storage/VillageStorage.ts | 2 +- src/TaskQueueRenderer.ts | 9 +- src/VillageController.ts | 2 +- src/VillageState.ts | 2 +- src/VillageTaskCollection.ts | 2 +- src/utils.ts | 112 ------------------ .../{UtilsTest.ts => Helpers/ConvertTest.ts} | 2 +- 48 files changed, 175 insertions(+), 163 deletions(-) create mode 100644 src/Helpers/Browser.ts create mode 100644 src/Helpers/Collection.ts create mode 100644 src/Helpers/Convert.ts create mode 100644 src/Helpers/Format.ts create mode 100644 src/Helpers/Identity.ts create mode 100644 src/Helpers/Random.ts create mode 100644 src/Helpers/Time.ts delete mode 100644 src/utils.ts rename tests/{UtilsTest.ts => Helpers/ConvertTest.ts} (94%) diff --git a/src/Action/ActionController.ts b/src/Action/ActionController.ts index 8ca1d22..d8c7a4e 100644 --- a/src/Action/ActionController.ts +++ b/src/Action/ActionController.ts @@ -1,11 +1,11 @@ import { Scheduler } from '../Scheduler'; import { taskError, TryLaterError } from '../Errors'; import { grabActiveVillageId } from '../Page/VillageBlock'; -import { aroundMinutes } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; import { VillageStorage } from '../Storage/VillageStorage'; import { VillageFactory } from '../VillageFactory'; +import { aroundMinutes } from '../Helpers/Time'; const actionMap: { [name: string]: Function | undefined } = {}; diff --git a/src/Action/BuildBuildingAction.ts b/src/Action/BuildBuildingAction.ts index c8f13ea..c24c65e 100644 --- a/src/Action/BuildBuildingAction.ts +++ b/src/Action/BuildBuildingAction.ts @@ -1,9 +1,9 @@ import { ActionController, registerAction } from './ActionController'; import { GrabError, taskError, TryLaterError } from '../Errors'; import { clickBuildButton } from '../Page/BuildingPage/BuildingPage'; -import { aroundMinutes } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; +import { aroundMinutes } from '../Helpers/Time'; @registerAction export class BuildBuildingAction extends ActionController { diff --git a/src/Action/CelebrationAction.ts b/src/Action/CelebrationAction.ts index dce3d56..ad0bd7a 100644 --- a/src/Action/CelebrationAction.ts +++ b/src/Action/CelebrationAction.ts @@ -1,9 +1,9 @@ import { ActionController, registerAction } from './ActionController'; import { GrabError, TryLaterError } from '../Errors'; -import { aroundMinutes } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; import { clickCelebrationButton } from '../Page/BuildingPage/GuildHallPage'; +import { aroundMinutes } from '../Helpers/Time'; @registerAction export class CelebrationAction extends ActionController { diff --git a/src/Action/FindSendResourcesPath.ts b/src/Action/FindSendResourcesPath.ts index e5cd59e..9d18c97 100644 --- a/src/Action/FindSendResourcesPath.ts +++ b/src/Action/FindSendResourcesPath.ts @@ -2,7 +2,6 @@ import { ActionController, registerAction } from './ActionController'; import { FailTaskError, taskError, TryLaterError } from '../Errors'; import { Resources } from '../Core/Resources'; import { Coordinates } from '../Core/Village'; -import { aroundMinutes, timestamp } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; import { clickSendButton, fillSendResourcesForm } from '../Page/BuildingPage/MarketPage'; @@ -17,6 +16,7 @@ import { import { ResourceTransferStorage } from '../Storage/ResourceTransferStorage'; import { path } from '../Helpers/Path'; import { MARKET_ID } from '../Core/Buildings'; +import { aroundMinutes, timestamp } from '../Helpers/Time'; @registerAction export class FindSendResourcesPath extends ActionController { diff --git a/src/Action/ForgeImprovementAction.ts b/src/Action/ForgeImprovementAction.ts index 98f0128..bf4208b 100644 --- a/src/Action/ForgeImprovementAction.ts +++ b/src/Action/ForgeImprovementAction.ts @@ -1,9 +1,9 @@ import { ActionController, registerAction } from './ActionController'; import { GrabError, taskError, TryLaterError } from '../Errors'; -import { aroundMinutes } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; import { clickResearchButton } from '../Page/BuildingPage/ForgePage'; +import { aroundMinutes } from '../Helpers/Time'; @registerAction export class ForgeImprovementAction extends ActionController { diff --git a/src/Action/SendOnAdventureAction.ts b/src/Action/SendOnAdventureAction.ts index 84f236d..c46d428 100644 --- a/src/Action/SendOnAdventureAction.ts +++ b/src/Action/SendOnAdventureAction.ts @@ -1,8 +1,8 @@ import { ActionController, registerAction } from './ActionController'; -import { trimPrefix } from '../utils'; import { AbortTaskError } from '../Errors'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; +import { trimPrefix } from '../Helpers/Convert'; const CONFIG = [ { level: 0, health: 60 }, diff --git a/src/Action/TrainTrooperAction.ts b/src/Action/TrainTrooperAction.ts index d8d7916..9e8b727 100644 --- a/src/Action/TrainTrooperAction.ts +++ b/src/Action/TrainTrooperAction.ts @@ -1,6 +1,5 @@ import { ActionController, registerAction } from './ActionController'; import { taskError, TryLaterError } from '../Errors'; -import { aroundMinutes, randomInRange } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; import { @@ -10,6 +9,8 @@ import { } from '../Page/BuildingPage/TrooperPage'; import { TrainTroopTask } from '../Task/TrainTroopTask'; import { Resources } from '../Core/Resources'; +import { randomInRange } from '../Helpers/Random'; +import { aroundMinutes } from '../Helpers/Time'; @registerAction export class TrainTrooperAction extends ActionController { diff --git a/src/Action/UpgradeBuildingAction.ts b/src/Action/UpgradeBuildingAction.ts index b16a94d..500c119 100644 --- a/src/Action/UpgradeBuildingAction.ts +++ b/src/Action/UpgradeBuildingAction.ts @@ -1,9 +1,9 @@ import { ActionController, registerAction } from './ActionController'; import { GrabError, TryLaterError } from '../Errors'; import { clickUpgradeButton } from '../Page/BuildingPage/BuildingPage'; -import { aroundMinutes } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; +import { aroundMinutes } from '../Helpers/Time'; @registerAction export class UpgradeBuildingAction extends ActionController { diff --git a/src/Action/UpgradeResourceToLevel.ts b/src/Action/UpgradeResourceToLevel.ts index 03f95b7..b1b4664 100644 --- a/src/Action/UpgradeResourceToLevel.ts +++ b/src/Action/UpgradeResourceToLevel.ts @@ -2,10 +2,11 @@ import { ActionController, registerAction } from './ActionController'; import { ActionError, taskError, TryLaterError } from '../Errors'; import { grabResourceSlots } from '../Page/SlotBlock'; import { UpgradeBuildingTask } from '../Task/UpgradeBuildingTask'; -import { aroundMinutes, getNumber } from '../utils'; import { Args } from '../Queue/Args'; import { Task } from '../Queue/TaskProvider'; import { ResourceSlot } from '../Core/Slot'; +import { getNumber } from '../Helpers/Convert'; +import { aroundMinutes } from '../Helpers/Time'; @registerAction export class UpgradeResourceToLevel extends ActionController { diff --git a/src/ControlPanel.ts b/src/ControlPanel.ts index c36fee5..d3e6d9e 100644 --- a/src/ControlPanel.ts +++ b/src/ControlPanel.ts @@ -1,4 +1,3 @@ -import { notify, parseLocation, timestamp, uniqId, waitForLoad } from './utils'; import { Scheduler } from './Scheduler'; import { BuildingPageController } from './Page/BuildingPageController'; import { UpgradeBuildingTask } from './Task/UpgradeBuildingTask'; @@ -21,6 +20,9 @@ import { Task } from './Queue/TaskProvider'; import { Action } from './Queue/ActionQueue'; import { createStore } from './DashboardView/Store'; import { VillageFactory } from './VillageFactory'; +import { uniqId } from './Helpers/Identity'; +import { timestamp } from './Helpers/Time'; +import { notify, parseLocation, waitForLoad } from './Helpers/Browser'; Vue.use(Vuex); diff --git a/src/DashboardView/LogList.vue b/src/DashboardView/LogList.vue index 1c1c2d0..ea5511b 100644 --- a/src/DashboardView/LogList.vue +++ b/src/DashboardView/LogList.vue @@ -13,8 +13,8 @@