av
2565d45bb5
Four agents reviewed this in parallel -- correctness, GNOME integration, edge cases, security. Everything below was reproduced before being fixed; several findings that survived the first reading did not survive a probe and are not here. State machine, the two that mattered most. A pending permission prompt was erased by any subagent bookkeeping event: SubagentStop or the next PreToolUse recomputed the state from scratch, so a session sat at "working" with a dialog open and nothing ever raised it again. Blocked now outlives everything except evidence the question was answered. Separately, the stale-event guard refused whole events, including the subagent counter's increments and decrements -- but those are deltas and deltas commute, so a "+1" that lost a timestamp race left the count short and the batch freed the session while a subagent was still running. The guard now gates the state decision only. Corrupt or hostile state files could wedge the panel or take the hook down for every session: a non-numeric pid raised inside sweep_dead before the hook wrote its own file, so one bad byte stopped new sessions appearing at all. Numbers read back from disk are coerced, one unreadable file no longer aborts the sweep, and a stored timestamp far in the future -- corruption, or a clock stepped backwards by NTP -- no longer refuses every later event forever. Resource bounds, all in the compositor process. A state file was read whole with no size check: a symlink to /dev/zero took a test process past 4 GB in three seconds, which in gnome-shell ends the session. Sizes are checked before the read, sessions and zellij subprocesses are capped, labels ellipsize, and cwd and messages are truncated at the hook. Teardown hung off an overridden destroy(), which only runs when JS calls it. An actor destroyed any other way -- another extension rebuilding the panel boxes -- left the timer and the file monitor running against a disposed actor. It is a destroy signal now. The zellij child is killed rather than merely abandoned. The glyph was pinned to physical pixels and rendered half-size on HiDPI; size comes from the stylesheet, and the foreground colour is normalised by inspection rather than assuming which colour struct the shell hands back. Chip labels: non-Latin names all collapsed to "?", because the split treated every Cyrillic letter as a separator -- notable for a tool whose own README is Russian. Seniority also ranked by time-in-state rather than session age, so after a shell restart the older session could take the digit; the hook now records when the session began. zellij: a dump ends with new_tab_template and swap_tiled_layout blocks whose tab lines carry no name, and their panes were being attached to the last real tab -- which then answered for every unmatched directory, confidently and wrongly. install.py no longer widens the mode of a settings.json someone narrowed to 0600, no longer overwrites the pristine .bak on a second run, no longer replaces a symlink out of a dotfiles repository with a regular file, and quotes the hook path. The debug log is capped and README now says plainly that it records prompts verbatim. Not fixed, deliberately: the panel does push the clock about 70 px left with three labelled chips, which is inherent to putting them in the centre box; two different projects abbreviating alike still read as one project with a digit; GNOME 48 remains unverified for the colour struct and for St.BoxLayout's vertical property, both flagged rather than guessed at.
57 lines
2.3 KiB
JavaScript
57 lines
2.3 KiB
JavaScript
// State glyphs, drawn with cairo alone.
|
|
//
|
|
// The panel is monochrome, so shape is the only channel left and the three
|
|
// states have to stay apart at 14 px. Kept free of St/Clutter/GNOME imports so
|
|
// the shapes can be rendered to a file and looked at, rather than guessed at.
|
|
|
|
/** Draw `state` filling the given box, in the colour passed as {r,g,b,a} 0..1. */
|
|
export function drawState(cr, state, width, height, color) {
|
|
const { r, g, b, a } = color;
|
|
const LINE = 1.75;
|
|
const cx = width / 2;
|
|
const cy = height / 2;
|
|
// Centreline of the ring. A stroke straddles it, so a disc filled to this
|
|
// radius reads visibly smaller than a ring drawn at it -- the filled states
|
|
// below use `outer` instead, which keeps every glyph the same size.
|
|
const radius = Math.min(width, height) / 2 - LINE;
|
|
const outer = radius + LINE / 2;
|
|
|
|
cr.setLineWidth(LINE);
|
|
cr.setSourceRGBA(r, g, b, a);
|
|
|
|
switch (state) {
|
|
case 'blocked':
|
|
// Disc inside a ring: the most ink of the three, for the only state
|
|
// where a session is stuck until you act. The inner disc has to be
|
|
// big enough to register at 14 px, or this reads as plain "working".
|
|
cr.arc(cx, cy, radius, 0, 2 * Math.PI);
|
|
cr.stroke();
|
|
// 0.55 of the ring radius: below that the centre stops registering at
|
|
// 14 px and this collapses into the "working" ring; above it the gap
|
|
// closes and it collapses into the "waiting" disc. Checked by
|
|
// rendering, not guessed.
|
|
cr.arc(cx, cy, radius * 0.55, 0, 2 * Math.PI);
|
|
cr.fill();
|
|
break;
|
|
case 'waiting':
|
|
cr.arc(cx, cy, outer, 0, 2 * Math.PI);
|
|
cr.fill();
|
|
break;
|
|
case 'busy':
|
|
cr.arc(cx, cy, radius, 0, 2 * Math.PI);
|
|
cr.stroke();
|
|
break;
|
|
default:
|
|
// Fallback for a state this build does not know, which should not
|
|
// happen: sessions.js normalises anything unrecognised to "waiting".
|
|
// Drawn dashed and dim so an unknown state looks uncertain rather than
|
|
// impersonating one of the three real ones.
|
|
cr.setDash([2, 2], 0);
|
|
cr.setSourceRGBA(r, g, b, a * 0.5);
|
|
cr.arc(cx, cy, radius, 0, 2 * Math.PI);
|
|
cr.stroke();
|
|
cr.setDash([], 0);
|
|
break;
|
|
}
|
|
}
|